sanpwc commented on a change in pull request #321:
URL: https://github.com/apache/ignite-3/pull/321#discussion_r704005614
##########
File path:
modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/RpcRequests.java
##########
@@ -48,6 +48,11 @@ private RpcRequests() {
* <code>optional string errorMsg = 2;</code>
*/
String errorMsg();
+
+ /**
+ * <code>optional string leaderId = 3;</code>
+ */
+ String leaderId();
Review comment:
Within the header of the file we have following warning
```
// Generated by the protocol buffer compiler. DO NOT EDIT!
// source: rpc.proto
```
Does it mean that given file is generated and shouldn't be edit?
inappropriate javadoc format.
Is it possible for leaderId to be null? Let's explicitly denote it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
