AMashenkov commented on a change in pull request #326: URL: https://github.com/apache/ignite-3/pull/326#discussion_r706047327
########## File path: modules/api/src/main/java/org/apache/ignite/query/sql/SqlSession.java ########## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.query.sql; + +import java.util.concurrent.TimeUnit; +import org.apache.ignite.query.sql.async.AsyncSqlSession; +import org.apache.ignite.query.sql.reactive.ReactiveSqlSession; +import org.apache.ignite.tx.Transaction; +import org.jetbrains.annotations.NotNull; + +/** + * SQL Session provides methods for query execution. + */ +public interface SqlSession extends AsyncSqlSession, ReactiveSqlSession { + /** + * Creates transactional SQL session projection with given transaction. + * + * @param tx Transaction. + * @return Transactional projection for the session. + */ + SqlTx withTransaction(@NotNull Transaction tx); + + /** + * Creates transactional SQL session projection with a new transaction. + * + * @return Transactional projection for the session. + */ + SqlTx withNewTransaction(); + + /** + * Sets default query timeout. + * + * @param timeout Query timeout value. + * @param timeUnit Timeunit. + */ + void defaultTimeout(int timeout, TimeUnit timeUnit); + + /** + * Gets default query timeout. + * + * @param timeUnit Timeunit. + * @return Default query timeout. + */ + long defaultTimeout(TimeUnit timeUnit); + + /** + * Sets default query schema. + * + * @param schema Default schema. + */ + void defaultSchema(@NotNull String schema); + + /** + * Gets default query schema. + * + * @return Default query schema. + */ + String defaultSchema(); + + /** + * Executes single SQL query. + * + * @param query SQL query template. + * @param arguments Arguments for the template (optional). + * @return SQL query results set. + * @throws SQLException If failed. + */ + SqlResultSet execute(@NotNull String query, Object... arguments); + + /** + * Executes single SQL statement. + * + * @param statement SQL statement to execute. + * @return SQL query results set. + */ + SqlResultSet execute(@NotNull SqlStatement statement); + + /** + * Executes multi-statement SQL query. + * + * @param query SQL query template. + * @param arguments Arguments for the template (optional). + * @return SQL query results set. + * @throws SQLException If failed. + */ + SqlMultiResultSet executeMulti(@NotNull String query, Object... arguments); Review comment: I'm not sure we need a Result here, but multi-statement can be useful. SQL scripts are supported in many databases, and widely used in applications for init or upgrade database schema. Why we should force user to split script into statements if Calcite is able to parse and execute them? So, we just need to add a method on public API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
