AMashenkov commented on a change in pull request #330:
URL: https://github.com/apache/ignite-3/pull/330#discussion_r708106468
##########
File path:
modules/schema/src/main/java/org/apache/ignite/internal/schema/mapping/ColumnMapper.java
##########
@@ -24,6 +24,7 @@
/**
* Column mapper interface.
*/
+// TODO: IGNITE-15480 Probably should be removed after index column mapping
refactoring.
Review comment:
> we don't need columnIndex (if you mean that column index here is
position in columns list).
I mean column index in Columns class. E,g, see SchemaDescriptor.keyCols.
We need a specific order for serialization: key columns prior to value
columns and fixlen types prior to varlen types.
Also, we want null-map to be a bitset.
##########
File path:
modules/schema/src/main/java/org/apache/ignite/internal/schema/mapping/ColumnMapper.java
##########
@@ -24,6 +24,7 @@
/**
* Column mapper interface.
*/
+// TODO: IGNITE-15480 Probably should be removed after index column mapping
refactoring.
Review comment:
> we don't need columnIndex (if you mean that column index here is
position in columns list).
I mean column index in Columns class. E,g, see SchemaDescriptor.keyCols.
We need a specific order for serialization: key columns prior to value
columns and fixlen types prior to varlen types.
Also, we want null-map to be a bitset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
