sanpwc commented on a change in pull request #330:
URL: https://github.com/apache/ignite-3/pull/330#discussion_r709388511
##########
File path:
modules/client-common/src/main/java/org/apache/ignite/internal/client/proto/ClientMessagePacker.java
##########
@@ -325,6 +326,33 @@ public ClientMessagePacker packUuid(UUID val) {
return this;
}
+ /**
+ * Writes an {@link IgniteUuid}.
+ *
+ * @param val {@link IgniteUuid} value.
+ * @return This instance.
+ */
+ public ClientMessagePacker packIgniteUuid(IgniteUuid val) {
Review comment:
Well I believe that it's possible to use different approach with
IgniteUUID in compassion to all other packing/unpacking logic in
ClientMessagePacker and it's unpacker counterpart, however it'll be confusing.
Current IgniteUUID packing approach is similar to UUID approach in
ClientMessagePacker that internally uses org.msgpack.core.MessagePacker, packer
close state, etc. Besides that there is a ticket for enhancement -
https://issues.apache.org/jira/browse/IGNITE-15234
As a result I believe that using utility method for IgniteUuid is out of the
scope of Ignite-15404 ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
