tledkov-gridgain commented on a change in pull request #398:
URL: https://github.com/apache/ignite-3/pull/398#discussion_r732565098
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/rel/AbstractIgniteJoin.java
##########
@@ -114,13 +113,13 @@ protected AbstractIgniteJoin(RelOptCluster cluster,
RelTraitSet traitSet, RelNod
List<Pair<RelTraitSet, List<RelTraitSet>>> pairs = new ArrayList<>();
pairs.add(Pair.of(nodeTraits.replace(RewindabilityTrait.ONE_WAY),
- ImmutableList.of(left.replace(RewindabilityTrait.ONE_WAY),
right.replace(RewindabilityTrait.ONE_WAY))));
+ List.of(left.replace(RewindabilityTrait.ONE_WAY),
right.replace(RewindabilityTrait.ONE_WAY))));
if (leftRewindability.rewindable() && rightRewindability.rewindable())
pairs.add(Pair.of(nodeTraits.replace(RewindabilityTrait.REWINDABLE),
- ImmutableList.of(left.replace(RewindabilityTrait.REWINDABLE),
right.replace(RewindabilityTrait.REWINDABLE))));
+ List.of(left.replace(RewindabilityTrait.REWINDABLE),
right.replace(RewindabilityTrait.REWINDABLE))));
- return ImmutableList.copyOf(pairs);
+ return List.copyOf(pairs);
Review comment:
The same like above: returns child of the `AbstractImmutableList`
instead of `ArrayList`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
