tledkov-gridgain commented on a change in pull request #398:
URL: https://github.com/apache/ignite-3/pull/398#discussion_r732582276
##########
File path:
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/planner/AbstractPlannerTest.java
##########
@@ -210,7 +211,7 @@ protected IgniteRel physicalPlan(String sql, IgniteSchema
publicSchema, String..
try (IgnitePlanner planner = ctx.planner()) {
assertNotNull(planner);
- planner.setDisabledRules(ImmutableSet.copyOf(disabledRules));
+ planner.setDisabledRules(new
HashSet<>(Arrays.asList(disabledRules)));
Review comment:
Not valid suggestion. `disabledRules` may contain duplicates.
ImmutableSet.copyOf throws `IllegalArgumentException` on duplicates. `new
HashSet` allow duplicates at initial collection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
