ptupitsyn commented on a change in pull request #9508:
URL: https://github.com/apache/ignite/pull/9508#discussion_r734647682
##########
File path: pom.xml
##########
@@ -653,11 +653,27 @@
project.setProperty(dest,
project.getProperty(source).replace("-SNAPSHOT",
""));
}
+
+ // When running nightly build,
'new.client.version' can be incompatible
+ // with .NET
AssemblyInformationalVersion requirements
+ // (i.e. 2.x.x.29394859 instead of
2.x.x).
+ // This function cuts excessive
part of version.
+ function setCutClientVersion(dest,
source) {
+ var value =
project.getProperty(source);
+ var digitVer =
/\d+\.\d+\.\d+/.exec(value);
Review comment:
I'm not sure it is correct to throw away a part of the version like
this. Especially for nightly builds, we should pack a pre-release version, not
a release one. Pre-release version is any version with a suffix like `-nightly`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
