ivandasch commented on a change in pull request #9508:
URL: https://github.com/apache/ignite/pull/9508#discussion_r734738688



##########
File path: pom.xml
##########
@@ -653,11 +653,27 @@
                                                 project.setProperty(dest, 
project.getProperty(source).replace("-SNAPSHOT",
                                                 ""));
                                             }
+                                            
+                                            // When running nightly build, 
'new.client.version' can be incompatible
+                                            // with .NET 
AssemblyInformationalVersion requirements 
+                                            // (i.e. 2.x.x.29394859 instead of 
2.x.x).
+                                            // This function cuts excessive 
part of version.
+                                            function setCutClientVersion(dest, 
source) {
+                                                var value = 
project.getProperty(source);
+                                                var digitVer = 
/\d+\.\d+\.\d+/.exec(value);

Review comment:
       It is not possible, unfortunately. AssemblyVersion must contain at most 
4 positive numbers, less than max uint16. 
   
   This regex just throw away current date, but it is preserved in zip archive 
of nugets. AFAIK nugets are published to some private repo (myget), so is it 
the real problem?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to