tkalkirill commented on a change in pull request #366:
URL: https://github.com/apache/ignite-3/pull/366#discussion_r738381614
##########
File path:
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/asm/ConfigurationAsmGenerator.java
##########
@@ -298,25 +405,29 @@ public synchronized void compileRootSchema(
schemasInfo.put(rootSchemaClass, new
SchemaClassesInfo(rootSchemaClass));
Set<Class<?>> schemas = new HashSet<>();
- List<ClassDefinition> definitions = new ArrayList<>();
+ List<ClassDefinition> classDefs = new ArrayList<>();
while (!compileQueue.isEmpty()) {
Class<?> schemaClass = compileQueue.poll();
assert schemaClass.isAnnotationPresent(ConfigurationRoot.class)
|| schemaClass.isAnnotationPresent(Config.class)
+ || isPolymorphicConfig(schemaClass)
: schemaClass + " is not properly annotated";
assert schemasInfo.containsKey(schemaClass) : schemaClass;
- Field[] schemaFields =
Arrays.stream(schemaClass.getDeclaredFields()).filter(
- field -> isValue(field) || isConfigValue(field) ||
isNamedConfigValue(field)
- ).toArray(Field[]::new);
+ Set<Class<?>> internalExtensions =
internalSchemaExtensions.getOrDefault(schemaClass, Set.of());
+ Set<Class<?>> polymorphicExtensions =
polymorphicSchemaExtensions.getOrDefault(schemaClass, Set.of());
+
+ assert internalExtensions.isEmpty() ||
polymorphicExtensions.isEmpty() :
Review comment:
Until there is a request from the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
