tkalkirill commented on a change in pull request #366:
URL: https://github.com/apache/ignite-3/pull/366#discussion_r738509109
##########
File path:
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/asm/ConfigurationAsmGenerator.java
##########
@@ -148,18 +181,48 @@
/** {@link ConstructableTreeNode#copy()} */
private static final Method COPY;
- /** {@link DynamicConfiguration#DynamicConfiguration} */
- private static final Constructor<?> DYNAMIC_CONFIGURATION_CTOR;
-
- /** {@link DirectDynamicConfiguration#DirectDynamicConfiguration} */
- private static final Constructor<?> DIRECT_DYNAMIC_CONFIGURATION_CTOR;
-
- /** {@link DynamicConfiguration#add(ConfigurationProperty)} */
- private static final Method DYNAMIC_CONFIGURATION_ADD;
+ /** {@code DynamicConfiguration#add} method. */
+ private static final Method DYNAMIC_CONFIGURATION_ADD_MTD;
/** {@link Objects#requireNonNull(Object, String)} */
private static final Method REQUIRE_NON_NULL;
+ /** {@link Class#getName} method. */
+ private static final Method CLASS_GET_NAME_MTD;
+
+ /** {@link String#equals} method. */
+ private static final Method STRING_EQUALS_MTD;
+
+ /** {@link ConfigurationSource#polymorphicTypeId} method. */
+ private static final Method POLYMORPHIC_TYPE_ID_MTD;
+
+ /** {@link InnerNode#constructDefault} method. */
+ private static final Method CONSTRUCT_DEFAULT_MTD;
+
+ /** {@code ConfigurationNode#refreshValue} method. */
+ private static final Method REFRESH_VALUE_MTD;
+
+ /** {@code PolymorphicDynamicConfiguration#addMember} method. */
+ private static final Method ADD_MEMBER_MTD;
+
+ /** {@code PolymorphicDynamicConfiguration#removeMember} method. */
+ private static final Method REMOVE_MEMBER_MTD;
+
+ /** {@link PolymorphicInnerNode#specificView} method. */
+ private static final Method SPECIFIC_VIEW_MTD;
+
+ /** {@link PolymorphicInnerNode#specificChange} method. */
+ private static final Method SPECIFIC_CHANGE_MTD;
+
+ /** {@link PolymorphicInnerNode#setPolymorphicTypeId} method. */
+ private static final Method SET_POLYMORPHIC_TYPE_ID_MTD;
+
+ /** {@link PolymorphicDynamicConfiguration#specificConfigTree} method. */
+ private static final Method SPECIFIC_CONFIG_TREE_MTD;
+
+ /** {@code Node#convert} method name. */
+ private static final String CONVERT_MTD_NAME = "convert";
Review comment:
It is used 3 times, I think we shouldn't inline it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
