Vladsz83 commented on a change in pull request #9535:
URL: https://github.com/apache/ignite/pull/9535#discussion_r739075991



##########
File path: 
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/DataTypesTest.java
##########
@@ -43,6 +43,59 @@
         qryEngine = Commons.lookupComponent(grid.context(), QueryEngine.class);
     }
 
+    /**
+     * Tests numeric types mapping on Java types.
+     */
+    @Test
+    public void testNumericTypes() {

Review comment:
       > seems we need additional test cover that all numeric types have 
expected type from table definition?
   
   Like `DataTypesTest#testNumericRanges()` ? it checks ranges and types.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to