alex-plekhanov commented on a change in pull request #9535:
URL: https://github.com/apache/ignite/pull/9535#discussion_r739172155
##########
File path:
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/DataTypesTest.java
##########
@@ -88,7 +152,16 @@ public void testUnicodeStrings() {
}
/** */
- public List<List<?>> executeSql(String sql, Object... params) {
+ private List<List<?>> executeSql(String sql, Object... params) {
return qryEngine.query(null, "PUBLIC", sql, params).get(0).getAll();
}
+
+ /** Checks type and value of single record result. */
+ static void assertSingleEquals(List<List<?>> result, Object val) {
Review comment:
All `assertXXX` methods usually use the first parameter as expected
result and the second parameter as the actual result.
Also, perhaps it's better to extend AbstractIntegrationTest and use standard
`assertQuery(sql).returns(expected result).check();` instead of this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
