ptupitsyn commented on a change in pull request #466:
URL: https://github.com/apache/ignite-3/pull/466#discussion_r755214677
##########
File path:
modules/network/src/main/java/org/apache/ignite/internal/network/netty/NettyServer.java
##########
@@ -331,47 +239,18 @@ public SocketAddress address() {
channel.close();
}
- return serverCloseFuture;
+ return serverCloseFuture == null ?
CompletableFuture.<Void>completedFuture(null) : serverCloseFuture;
}).thenCompose(Function.identity());
}
}
- /**
- * Shutdown event loops.
- */
- private void shutdownEventLoopGroups() {
- // TODO: IGNITE-14538 quietPeriod and timeout should be configurable.
- bossGroup.shutdownGracefully(0L, 15, TimeUnit.SECONDS);
- workerGroup.shutdownGracefully(0L, 15, TimeUnit.SECONDS);
- }
-
/**
* Returns {@code true} if the server is running, {@code false} otherwise.
*
* @return {@code true} if the server is running, {@code false} otherwise.
*/
@TestOnly
public boolean isRunning() {
- return channel != null && channel.isOpen() &&
!bossGroup.isShuttingDown() && !workerGroup.isShuttingDown();
- }
-
- /**
- * Returns acceptor event loop group.
- *
- * @return Acceptor event loop group.
- */
- @TestOnly
- public NioEventLoopGroup getBossGroup() {
- return bossGroup;
- }
-
- /**
- * Returns worker event loop group.
- *
- * @return Worker event loop group.
- */
- @TestOnly
- public NioEventLoopGroup getWorkerGroup() {
- return workerGroup;
+ return channel != null && channel.isOpen();
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
