ptupitsyn commented on a change in pull request #466:
URL: https://github.com/apache/ignite-3/pull/466#discussion_r755236437
##########
File path:
modules/network/src/main/java/org/apache/ignite/network/scalecube/ScaleCubeClusterServiceFactory.java
##########
@@ -37,23 +37,33 @@
import org.apache.ignite.network.AbstractClusterService;
import org.apache.ignite.network.ClusterLocalConfiguration;
import org.apache.ignite.network.ClusterService;
-import org.apache.ignite.network.ClusterServiceFactory;
+import org.apache.ignite.network.NettyBootstrapFactory;
import org.apache.ignite.network.NetworkAddress;
import org.apache.ignite.network.NodeFinder;
import org.apache.ignite.network.NodeFinderFactory;
import org.apache.ignite.network.serialization.MessageSerializationRegistry;
/**
- * {@link ClusterServiceFactory} implementation that uses ScaleCube for
messaging and topology services.
+ * Cluster service factory that uses ScaleCube for messaging and topology
services.
*/
-public class ScaleCubeClusterServiceFactory implements ClusterServiceFactory {
- /** {@inheritDoc} */
- @Override
- public ClusterService createClusterService(ClusterLocalConfiguration
context, NetworkConfiguration networkConfiguration) {
+public class ScaleCubeClusterServiceFactory {
+ /**
+ * Creates a new {@link ClusterService} using the provided context. The
created network will not be in the "started" state.
+ *
+ * @param context Cluster context.
+ * @param networkConfiguration Network configuration.
+ * @param nettyBootstrapFactory Bootstrap factory.
+ * @return New cluster service.
+ */
+ public ClusterService createClusterService(
+ ClusterLocalConfiguration context,
+ NetworkConfiguration networkConfiguration,
+ NettyBootstrapFactory nettyBootstrapFactory
+ ) {
var topologyService = new ScaleCubeTopologyService();
var messagingService = new ScaleCubeMessagingService();
-
+
Review comment:
This Slack is private, let me paste the screenshot here for clarity:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
