rpuch commented on a change in pull request #467:
URL: https://github.com/apache/ignite-3/pull/467#discussion_r755772332
##########
File path:
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/util/ConfigurationFlattener.java
##########
@@ -119,12 +120,21 @@ public Void doVisitLeafNode(String key, Serializable
newVal) {
return null;
}
-
+
+ @NotNull
+ private InnerNode currentOldInnerNode() {
Review comment:
1. To reduce code duplication
2. To avoid warnings all over the place. Idea thinks that
`oldInnerNodesStack.peek()` may return `null`, so the class looks like a
Christmas tree, which may mask real problems highlighted as warnings. With this
method, we let Idea know that it cannot return `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]