rpuch commented on a change in pull request #467:
URL: https://github.com/apache/ignite-3/pull/467#discussion_r755775383
##########
File path:
modules/configuration/src/test/java/org/apache/ignite/internal/configuration/notifications/ConfigurationListenerTest.java
##########
@@ -915,4 +957,17 @@ void testGetConfigFromNotificationEventOnUpdate() throws
Exception {
configuration.elements().get(key).str().update(newVal).get(1, SECONDS);
}
+
+ @Test
+ void
listenerGetsNotifiedOnCommonPropertyChangeInPolymorphicBaseConfigUnderNoNamedConfig()
throws Exception {
Review comment:
Well, the logic the test is verifying cannot be put in a couple of words
(there are several conditions that comprise the context of the test). A test
'method' is a method only technically; in reality, it's a 'test case', and it
seems good to capture 'what is being tested here' in its name.
If this does not convince you, how would you suggest to name it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
