rpuch commented on a change in pull request #467:
URL: https://github.com/apache/ignite-3/pull/467#discussion_r755798545
##########
File path:
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationChanger.java
##########
@@ -383,59 +383,68 @@ public SuperRoot superRoot() {
StorageRoots localRoots = storageRoots;
return CompletableFuture
- .supplyAsync(() -> {
Review comment:
Now the method looks like this:
```
private CompletableFuture<Void> changeInternally(ConfigurationSource
src) {
StorageRoots localRoots = storageRoots;
return CompletableFuture
.supplyAsync(() -> applyAndValidateChangesAndCalcDiff(src,
localRoots), pool)
.thenCompose(allChanges -> persistChanges(src, localRoots,
allChanges));
}
```
The top-level structure is seen immediately, in one glance. In the previous
state, it was 50+ lines long, and you had to actually read the code to see the
structure.
People are different, but for me this actually greatly improved the
readability of this part of code. I doubt that it worsened readability for
other people that much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
