[GitHub] [ignite-3] rpuch commented on a change in pull request #467: IGNITE-15971 Fix problems with dynamic configuration

Wed, 24 Nov 2021 00:27:54 -0800 


rpuch commented on a change in pull request #467:
URL: https://github.com/apache/ignite-3/pull/467#discussion_r755799898



##########
File path: 
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/tree/InnerNode.java
##########
@@ -52,29 +52,25 @@
      * @param <T>             Parameter type of the passed visitor.
      */
     public abstract <T> void traverseChildren(ConfigurationVisitor<T> visitor, 
boolean includeInternal);
-    
+
     /**
      * Method with auto-generated implementation. Must look like this:
      * <pre><code>
-     * {@literal @}Override public void traverseChild(String key, 
ConfigurationVisitor visitor, boolean includeInternal) throws
+     * {@literal @}Override public &lt;T&gt; T traverseChild(String key, 
ConfigurationVisitor visitor, boolean includeInternal) throws

Review comment:
       Added `<T>` there, too




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to