alex-plekhanov commented on a change in pull request #9490:
URL: https://github.com/apache/ignite/pull/9490#discussion_r759292957
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryReaderExImpl.java
##########
@@ -1364,10 +1364,16 @@ float readFloat(int fieldId) throws
BinaryObjectException {
@Nullable @Override public Object[] readObjectArray() throws
BinaryObjectException {
switch (checkFlag(OBJ_ARR)) {
case NORMAL:
- return BinaryUtils.doReadObjectArray(in, ctx, ldr, this,
false, true);
+ if (BinaryArray.useBinaryArrays())
+ return BinaryUtils.doReadBinaryArray(in, ctx, ldr, this,
false, true).deserialize(ldr);
+ else
+ return BinaryUtils.doReadObjectArray(in, ctx, ldr, this,
false, true);
case HANDLE:
- return readHandleField();
+ if (BinaryArray.useBinaryArrays())
Review comment:
It's safer to use `instanceof BinaryArray` in case we use
`doReadObjectArray` somewhere before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
