nizhikov commented on a change in pull request #9490:
URL: https://github.com/apache/ignite/pull/9490#discussion_r759371252
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheObjectUtils.java
##########
@@ -201,8 +203,10 @@ public static Object unwrapBinary(
return unwrapKnownCollection(ctx, (Collection<Object>)o,
keepBinary, cpy);
else if (BinaryUtils.knownMap(o))
return unwrapBinariesIfNeeded(ctx, (Map<Object, Object>)o,
keepBinary, cpy);
- else if (o instanceof Object[])
+ else if (o instanceof Object[] && !BinaryArray.useBinaryArrays())
Review comment:
This method creates new object on every invocation:
1. It's not good from performance perspective.
2. There are tests that check same object(by reference) returned so without
this condition tests fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
