Vladsz83 commented on a change in pull request #9457:
URL: https://github.com/apache/ignite/pull/9457#discussion_r772877136



##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/metric/impl/MetricUtils.java
##########
@@ -173,6 +174,34 @@ private static boolean ensureAllNamesNotEmpty(String... 
names) {
         return names;
     }
 
+    /**
+     * Gives proper name for service metric registry.
+     *
+     * @param srvcName Name of the service.
+     * @return registry name for service {@code srvcName}.
+     */
+    public static String serviceMetricRegistryName(String srvcName) {

Review comment:
       > This method used only within `IgniteServiceProcessor`, and use 
variable `SERVICE_METRIC_REGISTRY` from this class. I think we should move this 
method to the processor.
   
   It's also used in GridServiceMetricsTest.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to