Vladsz83 commented on a change in pull request #9457: URL: https://github.com/apache/ignite/pull/9457#discussion_r772965253
########## File path: modules/core/src/test/java/org/apache/ignite/internal/processors/service/GridServiceMetricsTest.java ########## @@ -0,0 +1,336 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.service; + +import java.lang.reflect.Method; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; +import java.util.stream.Collectors; +import java.util.stream.Stream; +import com.google.common.collect.Iterables; +import org.apache.ignite.configuration.IgniteConfiguration; +import org.apache.ignite.internal.IgniteEx; +import org.apache.ignite.internal.processors.metric.GridMetricManager; +import org.apache.ignite.internal.processors.service.inner.MyService; +import org.apache.ignite.internal.processors.service.inner.MyServiceFactory; +import org.apache.ignite.services.Service; +import org.apache.ignite.services.ServiceConfiguration; +import org.apache.ignite.spi.metric.HistogramMetric; +import org.apache.ignite.spi.metric.Metric; +import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry; +import org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi; +import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest; +import org.junit.Test; + +import static org.apache.ignite.internal.processors.metric.impl.MetricUtils.serviceMetricRegistryName; +import static org.apache.ignite.internal.processors.metric.impl.MetricUtils.sumHistogramEntries; +import static org.apache.ignite.internal.processors.service.IgniteServiceProcessor.SERVICE_METRIC_REGISTRY; + +/** + * Tests metrics of service invocations. + */ +public class GridServiceMetricsTest extends GridCommonAbstractTest { + /** Number of service invocations. */ + private static final int INVOKE_CNT = 50; + + /** Service name used in the tests. */ + private static final String SRVC_NAME = "TestService"; + + /** Error message of created metrics. */ + private static final String METRICS_MUST_NOT_BE_CREATED = "Service metric registry must not be created."; + + /** Utility holder of current grid number. */ + private int gridNum; + + /** {@inheritDoc} */ + @Override protected void afterTest() throws Exception { + stopAllGrids(); + + super.afterTest(); + } + + /** {@inheritDoc} */ + @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception { + IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName); + + // JMX metrics exposition to see actual namings and placement of the metrics. + cfg.setMetricExporterSpi(new JmxMetricExporterSpi()); + + return cfg; + } + + /** Checks service metrics are enabled / disabled properly. */ + @Test + public void testServiceMetricsEnabledDisabled() throws Exception { + IgniteEx ignite = startGrid(); + + ServiceConfiguration srvcCfg = serviceCfg(MyServiceFactory.create(), 0, 1); + + srvcCfg.setStatisticsEnabled(false); + + ignite.services().deploy(srvcCfg); + + assertNull(METRICS_MUST_NOT_BE_CREATED, findMetricRegistry(ignite.context().metric(), SRVC_NAME)); + + ignite.services().cancel(SRVC_NAME); + + srvcCfg.setStatisticsEnabled(true); + + ignite.services().deploy(srvcCfg); + + assertNotNull("Service metric registry must be created.", + findMetricRegistry(ignite.context().metric(), SRVC_NAME)); + } + + /** Checks metric behaviour when launched several service instances. */ + @Test + public void testMultipleDeployment() throws Throwable { + List<IgniteEx> servers = new ArrayList<>(); + + servers.add(startGrid(gridNum++)); + + IgniteEx server = servers.get(0); + + IgniteEx client = startClientGrid(gridNum++); + + assertNull(METRICS_MUST_NOT_BE_CREATED, findMetricRegistry(server.context().metric(), SERVICE_METRIC_REGISTRY)); + + int totalInstance = 2; + + int perNode = 2; + + ServiceConfiguration srvcCfg = serviceCfg(MyServiceFactory.create(), totalInstance, perNode); + + server.services().deploy(srvcCfg); + + awaitPartitionMapExchange(); + + // Call proxies on the clients. + Stream.generate(() -> client.services().serviceProxy(SRVC_NAME, MyService.class, true)) + .limit(totalInstance).forEach(srvc -> ((MyService)srvc).hello()); + + ReadOnlyMetricRegistry metrics = findMetricRegistry(server.context().metric(), SRVC_NAME); + + // Total service calls number. + int callsCnt = 0; + + for (Metric m : metrics) { + if (m instanceof HistogramMetric) + callsCnt += sumHistogramEntries((HistogramMetric)m); + } + + assertEquals(callsCnt, totalInstance); + + // Add servers more than service instances. + servers.add(startGrid(gridNum++)); + + servers.add(startGrid(gridNum++)); + + awaitPartitionMapExchange(); + + int deployedCnt = 0; + + int metricsCnt = 0; + + for (IgniteEx ignite : servers) { Review comment: Would look a bit weird. We rely on, iterate, get `servers` above. Why not using within the cycle? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
