timoninmaxim commented on a change in pull request #9457:
URL: https://github.com/apache/ignite/pull/9457#discussion_r774669080
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/metric/impl/MetricUtils.java
##########
@@ -173,6 +174,34 @@ private static boolean ensureAllNamesNotEmpty(String...
names) {
return names;
}
+ /**
+ * Gives proper name for service metric registry.
+ *
+ * @param srvcName Name of the service.
+ * @return registry name for service {@code srvcName}.
+ */
+ public static String serviceMetricRegistryName(String srvcName) {
Review comment:
So let's move it in `IgniteServiceProcessor` completely, and tests can
use this method from processor in static context also. I believe it's a bad
practice to have a method for tests usage, and in this case we can avoid it.
P.S. Now you have 2 similar methods, and unused import in
`IgniteServiceProcessor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
