rpuch commented on a change in pull request #559:
URL: https://github.com/apache/ignite-3/pull/559#discussion_r786624406
##########
File path:
modules/network/src/main/java/org/apache/ignite/internal/network/serialization/ClassDescriptor.java
##########
@@ -59,6 +65,20 @@
*/
private final boolean isFinal;
+ /** Total number of bytes needed to store all primitive fields. */
+ private final int primitiveFieldsDataSize;
+ /** Total number of object (i.e. non-primitive) fields. */
+ private final int objectFieldsCount;
+
+ private Map<String, FieldDescriptor> fieldsByName;
+ /**
+ * Offsets into primitive fields data (which has size {@link
#primitiveFieldsDataSize}).
+ * These are different from the offsets used in the context of {@link
sun.misc.Unsafe}.
Review comment:
'primitive fields data' is a byte array to which we collect values of
all primitive fields of the object. 'Offsets' are indices in this array. Unsafe
has nothing to do with this.
Do you suggest elaborating this in the comment even more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
