rpuch commented on a change in pull request #559:
URL: https://github.com/apache/ignite-3/pull/559#discussion_r786627042
##########
File path:
modules/network/src/main/java/org/apache/ignite/internal/network/serialization/ClassDescriptor.java
##########
@@ -305,4 +336,115 @@ public String toString() {
public boolean describesSameClass(ClassDescriptor other) {
return other.clazz() == clazz();
}
+
+ /**
+ * Returns total number of bytes needed to store all primitive fields.
+ *
+ * @return total number of bytes needed to store all primitive fields
+ */
+ public int primitiveFieldsDataSize() {
+ return primitiveFieldsDataSize;
+ }
+
+ /**
+ * Returns total number of object (i.e. non-primitive) fields.
+ *
+ * @return total number of object (i.e. non-primitive) fields
+ */
+ public int objectFieldsCount() {
+ return objectFieldsCount;
+ }
+
+ /**
+ * Return offset into primitive fields data (which has size {@link
#primitiveFieldsDataSize()}).
+ * These are different from the offsets used in the context of {@link
sun.misc.Unsafe}.
+ *
+ * @param fieldName primitive field name
+ * @param requiredType field type
+ * @return offset into primitive fields data
+ */
+ public int primitiveFieldDataOffset(String fieldName, Class<?>
requiredType) {
+ assert requiredType.isPrimitive();
+
+ if (fieldsByName == null) {
+ fieldsByName = fieldsByNameMap(fields);
+ }
+
+ FieldDescriptor fieldDesc = fieldsByName.get(fieldName);
+ if (fieldDesc == null) {
+ throw new IllegalStateException("Did not find a field with name "
+ fieldName);
+ }
+ if (fieldDesc.clazz() != requiredType) {
+ throw new IllegalStateException("Field " + fieldName + " has type
" + fieldDesc.clazz()
+ + ", but it was used as " + requiredType);
+ }
+
+ if (primitiveFieldDataOffsets == null) {
Review comment:
Yes, it's lazy initialization. The thing is that these structures are
only needed for putFields()/readFields() which are extremely rare in use. It
seems wasteful to initialize this always as we know that it will almost never
be used. And if we encounter readFields()/putFields(), we'll still do the
initialization just once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
