rpuch commented on a change in pull request #572:
URL: https://github.com/apache/ignite-3/pull/572#discussion_r788760836
##########
File path:
modules/network/src/main/java/org/apache/ignite/network/scalecube/ScaleCubeClusterServiceFactory.java
##########
@@ -159,7 +168,12 @@ public void stop() {
}
cluster.shutdown();
- cluster.onShutdown().block();
+
+ try {
+ shutdownFuture.get(10, TimeUnit.SECONDS);
+ } catch (InterruptedException | ExecutionException |
TimeoutException e) {
+ throw new IgniteInternalException("Unable to stop the
ClusterService", e);
Review comment:
Shouldn't we restore interruption status if we caught
`InterruptedException` here using `Thread.interrupt()`?
##########
File path:
modules/network/src/main/java/org/apache/ignite/network/scalecube/ScaleCubeClusterServiceFactory.java
##########
@@ -159,7 +168,12 @@ public void stop() {
}
cluster.shutdown();
- cluster.onShutdown().block();
+
+ try {
+ shutdownFuture.get(10, TimeUnit.SECONDS);
Review comment:
Why is it 10 seconds? Is it some estimate, or just a value that seems
sufficient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
