rpuch commented on a change in pull request #572:
URL: https://github.com/apache/ignite-3/pull/572#discussion_r788811447
##########
File path:
modules/network/src/main/java/org/apache/ignite/network/scalecube/ScaleCubeClusterServiceFactory.java
##########
@@ -159,7 +168,12 @@ public void stop() {
}
cluster.shutdown();
- cluster.onShutdown().block();
+
+ try {
+ shutdownFuture.get(10, TimeUnit.SECONDS);
Review comment:
The shutdown procedure leaves the cluster, shuts down membership,
gossip, metadata store and does not seem to wait for any long-running tasks (or
executors, if I didn't miss anything). So 10 seconds seems to be a good start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
