alex-plekhanov commented on a change in pull request #9751:
URL: https://github.com/apache/ignite/pull/9751#discussion_r791672857



##########
File path: 
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/ExecutionServiceImpl.java
##########
@@ -555,9 +565,16 @@ private QueryPlan prepareFragment(BaseQueryContext ctx, 
String jsonFragment) {
                             fragment.serialized(),
                             ectx.topologyVersion(),
                             fragmentDesc,
-                            qry.parameters());
+                            fragmentsPerNode.get(nodeId).intValue(),
+                            qry.parameters(),
+                            parametersMarshalled
+                        );
 
                         messageService().send(nodeId, req);
+
+                        // Avoid double marshaling.

Review comment:
       Marshaled parameters should be sent to each node, instead of marshaling 
it for each node, we can marshal it once, for the first node and then store it 
to sent it to other nodes. 

##########
File path: 
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/ExecutionServiceImpl.java
##########
@@ -555,9 +565,16 @@ private QueryPlan prepareFragment(BaseQueryContext ctx, 
String jsonFragment) {
                             fragment.serialized(),
                             ectx.topologyVersion(),
                             fragmentDesc,
-                            qry.parameters());
+                            fragmentsPerNode.get(nodeId).intValue(),
+                            qry.parameters(),
+                            parametersMarshalled
+                        );
 
                         messageService().send(nodeId, req);
+
+                        // Avoid double marshaling.

Review comment:
       Marshaled parameters should be sent to each node, instead of marshaling 
it for each node, we can marshal it once, for the first node and then store it 
to send it to other nodes. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to