ivandasch commented on a change in pull request #9751:
URL: https://github.com/apache/ignite/pull/9751#discussion_r791669190
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/ScanNode.java
##########
@@ -58,8 +60,20 @@ public ScanNode(ExecutionContext<Row> ctx, RelDataType
rowType, Iterable<Row> sr
requested = rowsCnt;
- if (!inLoop)
- context().execute(this::push, this::onError);
+ if (!inLoop) {
+ if (firstReq) {
Review comment:
This is simply not true, this is always win (context switching is not
for free)
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/ExecutionServiceImpl.java
##########
@@ -555,9 +565,16 @@ private QueryPlan prepareFragment(BaseQueryContext ctx,
String jsonFragment) {
fragment.serialized(),
ectx.topologyVersion(),
fragmentDesc,
- qry.parameters());
+ fragmentsPerNode.get(nodeId).intValue(),
+ qry.parameters(),
+ parametersMarshalled
+ );
messageService().send(nodeId, req);
+
+ // Avoid double marshaling.
Review comment:
It is quite obvious, just skip marshalling parameters on every
iteraration and reuse already done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
