AMashenkov commented on a change in pull request #9758:
URL: https://github.com/apache/ignite/pull/9758#discussion_r791742088



##########
File path: 
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/MappingQueryContext.java
##########
@@ -45,4 +53,16 @@ public UUID localNodeId() {
     public AffinityTopologyVersion topologyVersion() {
         return topVer;
     }
+
+    /** Creates a cluster. */
+    RelOptCluster cluster() {
+        if (cluster == null) {
+            cluster = 
RelOptCluster.create(Commons.emptyCluster().getPlanner(), 
Commons.emptyCluster().getRexBuilder());

Review comment:
       Seems, VolcanoPlanner can cache schemas (see 
VolcanoPlanner.registerSchema).
   Would you mind to fix the planner as well?
   
   We have similar fix in Ignite-3 (commit d87f1e18) with the method stub and 
tests looks fine.
   But I've tried to apply the same to your PR, but it lead to 2 tests (in 
PlannerTest) failure with no obvious reason.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to