AMashenkov commented on a change in pull request #9758:
URL: https://github.com/apache/ignite/pull/9758#discussion_r794518177
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/MappingQueryContext.java
##########
@@ -45,4 +53,16 @@ public UUID localNodeId() {
public AffinityTopologyVersion topologyVersion() {
return topVer;
}
+
+ /** Creates a cluster. */
+ RelOptCluster cluster() {
+ if (cluster == null) {
+ cluster =
RelOptCluster.create(Commons.emptyCluster().getPlanner(),
Commons.emptyCluster().getRexBuilder());
Review comment:
> I can add the same check to the planner as well, but now from my
point of view, it looks redundant.
I've tried to add the check to your PR code and found 2 tests failed because
planner registers schema in empty cluster.
(empty Cluster -> VolcanoPlanner -> registeredSchemas).
> Also, I think the fix for ignite-3 is not complete, we should attach
fragments to the empty cluster again before storing it to executionPlan variable
Looks like you are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
