ibessonov commented on a change in pull request #602:
URL: https://github.com/apache/ignite-3/pull/602#discussion_r798512230
##########
File path:
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/freelist/PagesList.java
##########
@@ -1379,14 +1377,7 @@ private byte getFlag(@Nullable IoVersions<?> initIoVers)
{
if (initIoVers != null) {
PageIo pageIo = initIoVers.latest();
- switch (pageIo.getType()) {
- case T_META:
- case T_DATA:
- case T_DATA_PART:
- return FLAG_DATA;
- default:
- return defaultPageFlag;
- }
+ return pageIo.getFlag() == FLAG_DATA ? FLAG_DATA : defaultPageFlag;
Review comment:
I'm pretty sure that you can return `pageIo.getFlag()`, we don't have
INDEX flag enymore
##########
File path:
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/freelist/PagesList.java
##########
@@ -1379,14 +1377,7 @@ private byte getFlag(@Nullable IoVersions<?> initIoVers)
{
if (initIoVers != null) {
PageIo pageIo = initIoVers.latest();
- switch (pageIo.getType()) {
- case T_META:
- case T_DATA:
- case T_DATA_PART:
- return FLAG_DATA;
- default:
- return defaultPageFlag;
- }
+ return pageIo.getFlag() == FLAG_DATA ? FLAG_DATA : defaultPageFlag;
Review comment:
I'm pretty sure that you can return `pageIo.getFlag()`, we don't have
INDEX flag anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
