ibessonov commented on a change in pull request #602:
URL: https://github.com/apache/ignite-3/pull/602#discussion_r798513005
##########
File path:
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/freelist/io/PagesListMetaIo.java
##########
@@ -51,7 +52,7 @@
* @param ver Page format version.
*/
private PagesListMetaIo(int ver) {
- super(T_PAGE_LIST_META, ver);
+ super(12, ver, FLAG_AUX);
Review comment:
So yeah, please introduce a constant. Why is it 12? We could start
numbering them from 1
##########
File path:
modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/PageIoRegistryEx.java
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.pagememory;
+
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import org.apache.ignite.internal.pagememory.io.IoVersions;
+import org.apache.ignite.internal.pagememory.io.PageIoRegistry;
+
+/**
+ * Extension (for tests) of {@link PageIoRegistry} to be able to add/replace
{@link IoVersions} not through {@link #loadFromServiceLoader}.
+ */
+public class PageIoRegistryEx extends PageIoRegistry {
Review comment:
Can we name it `TestPageIoRegistry`? "Ex" has nothing to do with its
purpose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
