rpuch commented on a change in pull request #670:
URL: https://github.com/apache/ignite-3/pull/670#discussion_r809933458
##########
File path:
modules/network/src/main/java/org/apache/ignite/internal/network/serialization/ClassDescriptor.java
##########
@@ -52,21 +52,28 @@
@Nullable
private final ClassDescriptor superClassDescriptor;
+ /**
+ * Component type descriptor (only present for arrays).
+ */
+ @Nullable
+ private final ClassDescriptor componentTypeDescriptor;
+
+ private final boolean isPrimitive;
+ private final boolean isArray;
+ private final boolean isRuntimeEnum;
+ private final boolean isRuntimeTypeKnownUpfront;
+
/**
* List of the declared class fields' descriptors.
*/
- @NotNull
private final List<FieldDescriptor> fields;
/**
* How the class is to be serialized.
*/
private final Serialization serialization;
- /**
- * Whether the class is final.
- */
- private final boolean isFinal;
+ private final List<MergedField> mergedFields;
Review comment:
The only thing I can invent as a javadoc here is 'The merged fields', it
gives no additional information, just duplication. If something is missing,
could you please suggest what you'd like to see in the Javadoc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
