rpuch commented on a change in pull request #670: URL: https://github.com/apache/ignite-3/pull/670#discussion_r810816319
########## File path: modules/network/src/main/java/org/apache/ignite/internal/network/serialization/MergedField.java ########## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.network.serialization; + +import java.util.Objects; + +/** + * Contains information about a field, both from local and remote classes. Any of the parts (local/remote) might be absent. + */ +public class MergedField { + private final FieldDescriptor localField; + private final FieldDescriptor remoteField; + + /** + * Creates a {@link MergedField} for the case when there is only local part. + * + * @param localField local part + * @return merged field + */ + public static MergedField localOnly(FieldDescriptor localField) { + return new MergedField(localField, null); + } + + /** + * Creates a {@link MergedField} for the case when there is only remote part. + * + * @param remoteField remote part + * @return merged field + */ + public static MergedField remoteOnly(FieldDescriptor remoteField) { + return new MergedField(null, remoteField); + } + + /** + * Creates a new {@link MergedField}. + * + * @param localField local part + * @param remoteField remote part + */ + public MergedField(FieldDescriptor localField, FieldDescriptor remoteField) { + if (localField == null && remoteField == null) { + throw new IllegalArgumentException("Both descriptors are null"); + } + if (localField != null && remoteField != null && !localField.name().equals(remoteField.name())) { Review comment: Turned them to assertions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
