sashapolo commented on a change in pull request #723:
URL: https://github.com/apache/ignite-3/pull/723#discussion_r829842765
##########
File path:
modules/metastorage-server/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java
##########
@@ -179,25 +179,30 @@ public void start() {
ColumnFamilyOptions indexFamilyOptions = new
ColumnFamilyOptions(indexOptions);
- List<ColumnFamilyDescriptor> descriptors = Arrays.asList(
+ return List.of(
new ColumnFamilyDescriptor(DATA.nameAsBytes(),
dataFamilyOptions),
Review comment:
I had a thought about that. I think that it is ok if options will be
closed by the GC for the following reasons:
1. It is quite cumbersome to pass these options everywhere in order for them
to be closed.
2. We create only a couple of these objects during the entire life of an
Ignite node, so it's ok if they hang out in the heap for a while.
3. We actually very rarely get rid of these objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
