sashapolo commented on a change in pull request #723:
URL: https://github.com/apache/ignite-3/pull/723#discussion_r829941866
##########
File path:
modules/metastorage-server/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java
##########
@@ -218,78 +223,33 @@ private void destroyRocksDb() throws RocksDBException {
public void close() throws Exception {
IgniteUtils.shutdownAndAwaitTermination(snapshotExecutor, 10,
TimeUnit.SECONDS);
Review comment:
> So, in our case, this would mean that MetaStorageManager (the class
that now stops RocksDbKeyValueStorage) would need to make sure that all the
futures are resolved?
yes
> Currently, its stop() method does not seem to bother about it explicitly,
but maybe I'm missing something here.
because it's not entirely correct =)
I think I will create a ticket to properly implement the component's stop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
