tkalkirill commented on code in PR #763:
URL: https://github.com/apache/ignite-3/pull/763#discussion_r846019108
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/StorageEngineFactory.java:
##########
@@ -18,16 +18,26 @@
package org.apache.ignite.internal.storage.engine;
import java.nio.file.Path;
+import
org.apache.ignite.configuration.schemas.store.DataStorageConfigurationSchema;
import org.apache.ignite.internal.configuration.ConfigurationRegistry;
import org.apache.ignite.internal.storage.StorageException;
/**
* Factory for creating storage engines.
*/
public interface StorageEngineFactory {
+ /**
+ * Returns the unique name of the storage engine.
+ *
+ * <p>Used to map {@link DataStorageConfigurationSchema#name} to {@link
StorageEngine}.
+ */
+ String name();
+
/**
* Creates a new storage engine.
*
+ * <p>NOTE: {@code configRegistry} has not started yet, so only the root
configuration can be retrieved.
Review Comment:
Rechecked, my comment is meaningless, deleted it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
