tkalkirill commented on code in PR #763:
URL: https://github.com/apache/ignite-3/pull/763#discussion_r846031826
##########
modules/storage-rocksdb/src/test/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorageTest.java:
##########
@@ -73,21 +75,27 @@ public void setUp(
@InjectConfiguration RocksDbStorageEngineConfiguration
rocksDbEngineConfig,
@InjectConfiguration(
name = "table",
- polymorphicExtensions =
{HashIndexConfigurationSchema.class,
RocksDbDataStorageConfigurationSchema.class}
+ polymorphicExtensions = {
+ HashIndexConfigurationSchema.class,
+ UnknownDataStorageConfigurationSchema.class,
+ RocksDbDataStorageConfigurationSchema.class
+ }
) TableConfiguration tableCfg
) throws Exception {
- assertThat(tableCfg.dataStorage(),
is(instanceOf(RocksDbDataStorageConfiguration.class)));
+ CompletableFuture<Void> changeDataStorageFuture =
tableCfg.dataStorage().change(c -> c.convert(RocksDbDataStorageChange.class));
Review Comment:
I didn’t quite understand, but if it’s a minor, then we’ll leave it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
