sk0x50 commented on code in PR #769:
URL: https://github.com/apache/ignite-3/pull/769#discussion_r848297241
##########
modules/network/src/main/java/org/apache/ignite/network/scalecube/ScaleCubeClusterServiceFactory.java:
##########
@@ -157,10 +157,10 @@ public void stop() {
Thread.currentThread().interrupt();
throw new IgniteInternalException("Interrupted while
waiting for the ClusterService to stop", e);
- } catch (TimeoutException e) {
- throw new IgniteInternalException("Timeout while waiting
for the ClusterService to stop", e);
} catch (ExecutionException e) {
throw new IgniteInternalException("Unable to stop the
ClusterService", e.getCause());
+ } catch (TimeoutException ignored) {
+ // Failed to leave gracefully
Review Comment:
Perhaps, it makes sense to log a warning message here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
