sk0x50 commented on code in PR #769:
URL: https://github.com/apache/ignite-3/pull/769#discussion_r848300474
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/JRaftServiceFactory.java:
##########
@@ -31,11 +31,11 @@ public interface JRaftServiceFactory {
/**
* Creates a raft log storage.
*
- * @param uri The log storage uri from {@link NodeOptions#getSnapshotUri()}
+ * @param groupId The name of the raft group.
* @param raftOptions the raft options.
* @return storage to store raft log entires.
*/
- LogStorage createLogStorage(final String uri, final RaftOptions
raftOptions);
+ LogStorage createLogStorage(final String groupId, final RaftOptions
raftOptions);
Review Comment:
Everything else works with the URI. Why is this change needed? It doesn't
look very consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
