ibessonov commented on code in PR #800:
URL: https://github.com/apache/ignite-3/pull/800#discussion_r871051971
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointMarkersStorage.java:
##########
@@ -136,15 +128,13 @@ public void onCheckpointEnd(UUID checkpointId) throws
IgniteInternalCheckedExcep
throw new IgniteInternalCheckedException("Could not create end
checkpoint marker: " + checkpointEndMarker, e);
}
- if (checkpointIds.size() >= earliestCheckpointChangesThreshold) {
- for (Iterator<UUID> it = checkpointIds.iterator(); it.hasNext(); )
{
- UUID id = it.next();
+ for (Iterator<UUID> it = checkpointIds.iterator(); it.hasNext(); ) {
Review Comment:
I'd argue that we should just leave these markers indefinitely, but who
cares. Because we will remove this loop in the future anyways
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
