ibessonov commented on code in PR #800:
URL: https://github.com/apache/ignite-3/pull/800#discussion_r871053529
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointMarkersStorage.java:
##########
@@ -136,15 +128,13 @@ public void onCheckpointEnd(UUID checkpointId) throws
IgniteInternalCheckedExcep
throw new IgniteInternalCheckedException("Could not create end
checkpoint marker: " + checkpointEndMarker, e);
}
- if (checkpointIds.size() >= earliestCheckpointChangesThreshold) {
- for (Iterator<UUID> it = checkpointIds.iterator(); it.hasNext(); )
{
- UUID id = it.next();
+ for (Iterator<UUID> it = checkpointIds.iterator(); it.hasNext(); ) {
Review Comment:
You know, it's funny that if node breaks during marker removal, and leaves
END marker, deleting START at the same time - node just won't start. Just
sayin'. No need to fix it right now, as I mentioned, a lot of thing will be
revisited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
