SammyVimes commented on code in PR #804:
URL: https://github.com/apache/ignite-3/pull/804#discussion_r872308832
##########
modules/network/src/main/java/org/apache/ignite/internal/network/handshake/HandshakeManager.java:
##########
@@ -28,29 +27,23 @@
*/
public interface HandshakeManager {
/**
- * Initialize handshake manager with the channel.
+ * Initializes handshake manager with the channel.
*
- * @param channel Channel.
- * @return Action to perform by {@link HandshakeHandler}.
+ * @param handlerContext Channel handler context.
*/
- HandshakeResult init(Channel channel);
+ void onInit(ChannelHandlerContext handlerContext);
Review Comment:
To make naming consistent (see other methods). It's event handling and I
prefer "on" + EventName
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
