SammyVimes commented on code in PR #804:
URL: https://github.com/apache/ignite-3/pull/804#discussion_r872318472
##########
modules/network/src/main/java/org/apache/ignite/internal/network/netty/ConnectionManager.java:
##########
@@ -221,17 +226,17 @@ private void onNewIncomingChannel(NettySender channel) {
* @param address Target address.
* @return New netty client.
*/
- private NettyClient connect(SocketAddress address) {
+ private NettyClient connect(SocketAddress address, short connectionId) {
var client = new NettyClient(
address,
serializationService,
- clientHandshakeManagerFactory.get(),
+ createClientHandshakeManager(connectionId),
this::onMessage
);
- client.start(clientBootstrap).whenComplete((sender, throwable) -> {
+ client.start(clientBootstrap).whenComplete((nodeInfo, throwable) -> {
if (throwable == null) {
- channels.put(sender.consistentId(), sender);
Review Comment:
Whoops, some leftovers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
