sashapolo commented on code in PR #795:
URL: https://github.com/apache/ignite-3/pull/795#discussion_r877998380
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/raft/CmgRaftService.java:
##########
@@ -153,11 +180,30 @@ public Set<String> nodeNames() {
.collect(Collectors.toSet());
}
+ /**
+ * Converts a {@link Peer} into a {@link ClusterNode}.
+ *
+ * <p>This method tries to resolve the given {@code peer} multiple times,
because it might be offline temporarily.
+ */
private ClusterNode resolvePeer(Peer peer) {
- ClusterNode node =
clusterService.topologyService().getByAddress(peer.address());
+ NetworkAddress addr = peer.address();
+
+ for (int i = 0; i < MAX_RESOLVE_ATTEMPTS; ++i) {
Review Comment:
hm, I actually have a habit of putting it on the left side, but I don't see
any difference with the right side. I'll change that if it makes you
uncomfortable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
