sashapolo commented on code in PR #795:
URL: https://github.com/apache/ignite-3/pull/795#discussion_r878113626


##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -429,11 +426,21 @@ public CompletableFuture<Ignite> start(@Language("HOCON") 
@Nullable String cfg)
                                 fut -> new 
ConfigurationCatchUpListener(cfgStorage, fut, LOG)
                         );
 
-                        return 
CompletableFuture.allOf(notifyConfigurationListeners(), recoveryFuture);
+                        return notifyConfigurationListeners()
+                                .thenCompose(t -> {
+                                    // Deploy all registered watches because 
all components are ready and have registered their listeners.
+                                    try {
+                                        metaStorageMgr.deployWatches();

Review Comment:
   AFAIK, `deployWatches` should be called only after initial configuration 
notification listeners are notified 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to