PakhomovAlexander commented on code in PR #816: URL: https://github.com/apache/ignite-3/pull/816#discussion_r887328215
########## modules/cluster-management/src/integrationTest/java/org/apache/ignite/internal/cluster/management/rest/ItClusterManagementControllerTest.java: ########## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.cluster.management.rest; + +import static org.apache.ignite.internal.testframework.matchers.CompletableFutureMatcher.willCompleteSuccessfully; +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.Matchers.equalTo; +import static org.hamcrest.Matchers.is; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertThrows; + +import io.micronaut.context.annotation.Bean; +import io.micronaut.context.annotation.Factory; +import io.micronaut.context.annotation.Replaces; +import io.micronaut.http.HttpRequest; +import io.micronaut.http.HttpResponse; +import io.micronaut.http.HttpStatus; +import io.micronaut.http.client.HttpClient; +import io.micronaut.http.client.annotation.Client; +import io.micronaut.http.client.exceptions.HttpClientResponseException; +import io.micronaut.runtime.server.EmbeddedServer; +import io.micronaut.test.extensions.junit5.annotation.MicronautTest; +import jakarta.inject.Inject; +import java.io.IOException; +import java.nio.file.Path; +import java.util.ArrayList; +import java.util.List; +import org.apache.ignite.internal.cluster.management.ClusterInitializer; +import org.apache.ignite.internal.cluster.management.MockNode; +import org.apache.ignite.internal.rest.api.ErrorResult; +import org.apache.ignite.internal.testframework.WorkDirectory; +import org.apache.ignite.internal.testframework.WorkDirectoryExtension; +import org.apache.ignite.network.ClusterService; +import org.apache.ignite.network.NetworkAddress; +import org.apache.ignite.network.StaticNodeFinder; +import org.jetbrains.annotations.NotNull; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.TestInfo; +import org.junit.jupiter.api.extension.ExtendWith; + +/** + * Cluster management REST test. + */ +@MicronautTest +@ExtendWith(WorkDirectoryExtension.class) +public class ItClusterManagementControllerTest { + + private static final int PORT_BASE = 10000; + + private static final List<MockNode> cluster = new ArrayList<>(); + static ClusterService clusterService; + @WorkDirectory + private static Path workDir; + @Inject + EmbeddedServer server; + @Inject + @Client("/management/v1/cluster/init/") + HttpClient client; + @Inject + ClusterInitializer clusterInitializer; + + @BeforeAll + static void setUp(TestInfo testInfo) throws IOException { + var addr1 = new NetworkAddress("localhost", PORT_BASE); + var addr2 = new NetworkAddress("localhost", PORT_BASE + 1); + + var nodeFinder = new StaticNodeFinder(List.of(addr1, addr2)); + + cluster.add(new MockNode(testInfo, addr1, nodeFinder, workDir.resolve("node0"))); + cluster.add(new MockNode(testInfo, addr2, nodeFinder, workDir.resolve("node1"))); + + for (MockNode node : cluster) { + node.start(); + } + + clusterService = cluster.get(0).clusterService(); + } + + @AfterAll + static void tearDown() { + for (MockNode node : cluster) { + node.beforeNodeStop(); + } + + for (MockNode node : cluster) { + node.stop(); + } + } + + @Test + void testControllerLoaded() { + assertNotNull(server.getApplicationContext().getBean(ClusterManagementController.class)); + } + + @Test + void testInitNoSuchNode() { + // Given body with nodename that does not exist + String givenInvalidBody = "{\"metaStorageNodes\": [\"nodename\"], \"cmgNodes\": [], \"clusterName\": \"cluster\"}"; + + // When + var thrown = assertThrows( + HttpClientResponseException.class, + () -> client.toBlocking().exchange(HttpRequest.POST("", givenInvalidBody)) + ); + + // Then + assertThat(thrown.getResponse().getStatus(), is(equalTo((HttpStatus.BAD_REQUEST)))); + // And + var errorResult = getErrorResult(thrown); + assertEquals("INVALID_NODES", errorResult.type()); + } + + @Test + void testInitAlreadyInitializedWithAnotherNodes() { + // Given cluster initialized + String givenFirstRequestBody = + "{\"metaStorageNodes\": [\"" + cluster.get(0).clusterService().localConfiguration().getName() + "\"], \"cmgNodes\": [], " + + "\"clusterName\": \"cluster\"}"; + + // When + HttpResponse<Object> response = client.toBlocking().exchange(HttpRequest.POST("", givenFirstRequestBody)); + + // Then + assertThat(response.getStatus(), is(equalTo((HttpStatus.OK)))); + // And + assertThat(cluster.get(0).startFuture(), willCompleteSuccessfully()); + + // Given second request with different node name + String givenSecondRequestBody = + "{\"metaStorageNodes\": [\"" + cluster.get(1).clusterService().localConfiguration().getName() + "\"], \"cmgNodes\": [], " + + "\"clusterName\": \"cluster\" }"; + + // When + var thrown = assertThrows( + HttpClientResponseException.class, + () -> client.toBlocking().exchange(HttpRequest.POST("", givenSecondRequestBody)) + ); + + // Then + assertThat(thrown.getResponse().getStatus(), is(equalTo((HttpStatus.CONFLICT)))); + // And + var errorResult = getErrorResult(thrown); + assertEquals("ALREADY_INITIALIZED", errorResult.type()); + + } + + @Factory + @Bean + @Replaces(ClusterManagementRestFactory.class) + public ClusterManagementRestFactory clusterManagementRestFactory() { + return new ClusterManagementRestFactory(clusterService); + } + + @NotNull Review Comment: > It's not a JSON, but it's not just any plain text. Could we use a specific content type here? For example, here https://www.w3schools.io/file/hocon-introduction/ they suggest application/hocon; it does not seem to be registered with IANA, but it looks logical. Yes, you are right, that sounds logical. But client generators get confused when you set content type that is not registered with IANA. I tried this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
