PakhomovAlexander commented on code in PR #816:
URL: https://github.com/apache/ignite-3/pull/816#discussion_r887334337
##########
modules/cli/src/integrationTest/java/org/apache/ignite/cli/ItConfigCommandTest.java:
##########
@@ -113,9 +109,7 @@ public void setAndGetWithManualHost() {
assertEquals(0, exitCode);
- DocumentContext document =
JsonPath.parse(removeTrailingQuotes(unescapeQuotes(out.toString(UTF_8))));
-
- assertEquals(1, document.read("$.network.shutdownQuietPeriod",
Integer.class));
+ assertTrue(out.toString(UTF_8).contains("\"shutdownQuietPeriod\" :
1"));
Review Comment:
> would it be possible to restore the parsing to make sure it's a valid
HOCON?
Good point. I'd like to create a ticket for this because it seems like a lot
of tests should be adjusted. Also, I think it is better to check in the server
tests instead of in CLI tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
