tkalkirill commented on code in PR #861:
URL: https://github.com/apache/ignite-3/pull/861#discussion_r891254895
##########
modules/configuration/src/test/java/org/apache/ignite/internal/configuration/testframework/ConfigurationExtension.java:
##########
@@ -227,7 +228,10 @@ private static Object cfgValue(
ConfigurationUtil.addDefaults(superRoot);
if (!annotation.name().isEmpty()) {
-
superRoot.getRoot(rootKey).setInjectedNameFieldValue(annotation.name());
+ InnerNode root = superRoot.getRoot(rootKey);
+
+ root.internalId(UUID.randomUUID());
Review Comment:
Please add a test here
`org.apache.ignite.internal.configuration.testframework.ConfigurationExtensionTest`
to check if the behavior is correct.
##########
modules/storage-api/src/test/java/org/apache/ignite/internal/storage/AbstractPartitionStorageTest.java:
##########
@@ -168,13 +168,13 @@ public void scanFiltered() throws Exception {
storage.write(dataRow1);
storage.write(dataRow2);
- List<DataRow> list = toList(storage.scan(key -> key.keyBytes()[3] ==
'1'));
+ List<DataRow> list = toList(storage.scan(key ->
key.key().get(key.key().limit() - 1) == '1'));
assertThat(list, hasSize(1));
assertArrayEquals(dataRow1.value().array(),
list.get(0).value().array());
- list = toList(storage.scan(key -> key.keyBytes()[3] == '2'));
+ list = toList(storage.scan(key -> key.key().get(key.key().limit() - 1)
== '2'));
Review Comment:
Can use `key.key().get(3)` ?
##########
modules/storage-api/src/test/java/org/apache/ignite/internal/storage/AbstractPartitionStorageTest.java:
##########
@@ -168,13 +168,13 @@ public void scanFiltered() throws Exception {
storage.write(dataRow1);
storage.write(dataRow2);
- List<DataRow> list = toList(storage.scan(key -> key.keyBytes()[3] ==
'1'));
+ List<DataRow> list = toList(storage.scan(key ->
key.key().get(key.key().limit() - 1) == '1'));
Review Comment:
Can use `key.key().get(3)` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
